DSD-1642: Updating Page Layout components to Chakra 2.8 theme API #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your pull request is missing a changelog—was that intentional? |
7emansell
force-pushed
the
DSD-1642/page-layout
branch
from
3473baa
to
395c44d
Compare
EdwinGuzman
reviewed
Jan 11, 2024
| export const HorizontalRule: ChakraComponent< | ||
| React.ForwardRefExoticComponent< | ||
| React.PropsWithChildren<HorizontalRuleProps> & | ||
| React.RefAttributes<HTMLHRElement> |
There was a problem hiding this comment.
This should be HTMLDivElement & HTMLHRElement
EdwinGuzman
reviewed
Jan 11, 2024
| @@ -33,6 +35,7 @@ import Link from "../Link/Link"; | |||
| - {<Link href="#template-children-overview">Template Children Overview</Link>} | |||
| - {<Link href="#template-children-component-props">Template Children Component Props</Link>} | |||
| - {<Link href="#full-example-with-template-children-components">Full Example with Template Children Components</Link>} | |||
| - {<Link href="#changelog" target="_self">Changelog</Link>} | |||
There was a problem hiding this comment.
Can you also update the latest version to "Prerelease"?
EdwinGuzman
reviewed
Jan 11, 2024
There was a problem hiding this comment.
This looks good. There's a merge conflict on strucutredContent.ts and I think that will fix some styling issues I see now for the Headings. Can you merge that in, fix, and update?
Also, images don't always load but there's a PR for that. If you can review that, that'd be great #1489
EdwinGuzman
approved these changes
Jan 11, 2024
bigfishdesign13
added
the
Ship It
7emansell
force-pushed
the
DSD-1642/page-layout
branch
from
0f1e1dd
to
9cc6b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIRA ticket DSD-1642.
This PR does the following:
How has this been tested?
Locally, Storybook
Accessibility concerns or updates
Checklist:
Front End Review: