Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSD-1632: QA fix - update padding to fix focus outline #1510

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jackiequach
Copy link
Collaborator

Fixes JIRA ticket DSD-1632

This PR does the following:

  • Update padding to fix the focus outline around tabs. This issue is a result of changing overflow-x from visible to scroll, which causes the inner content to be clipped by the parent.

How has this been tested?

Locally on storybook

Accessibility concerns or updates

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview Feb 1, 2024 9:35pm

Copy link

github-actions bot commented Feb 1, 2024

Your pull request is missing a changelog—was that intentional?

Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It still looks off but only in the Docs page. So let Alkim know that it's because of how Storybook displays the iframes inside the Docs page. Otherwise, in the "With Controls" tab, the issue with the first and last tabs look okay:
Screen Shot 2024-02-02 at 10 16 30 AM

@EdwinGuzman EdwinGuzman added the Ship It Pull requests that have been reviewed and approved. label Feb 2, 2024
@jackiequach jackiequach merged commit 8247ab0 into development Feb 2, 2024
5 checks passed
@jackiequach jackiequach deleted the DSD-1632/fix-qa-issues branch February 2, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants