Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSD-1690: color manager export #1523

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

EdwinGuzman
Copy link
Member

Fixes JIRA ticket DSD-1690

This PR does the following:

How has this been tested?

Will be tested in release candidate in Turbine.

Accessibility concerns or updates

  • N/A

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@EdwinGuzman EdwinGuzman added the Needs Review Pull requests that are ready for peer review. label Feb 14, 2024
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ❌ Failed (Inspect) Feb 22, 2024 3:12pm

@EdwinGuzman EdwinGuzman changed the base branch from development to react18-and-chakra February 14, 2024 17:23
Copy link

Your pull request is missing a changelog—was that intentional?

Copy link
Collaborator

@bigfishdesign13 bigfishdesign13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bigfishdesign13 bigfishdesign13 added Ship It Pull requests that have been reviewed and approved. and removed Needs Review Pull requests that are ready for peer review. labels Feb 21, 2024
@EdwinGuzman EdwinGuzman merged commit 5870af7 into react18-and-chakra Feb 22, 2024
4 of 5 checks passed
@EdwinGuzman EdwinGuzman deleted the DSD-1690/color-manager-export branch March 4, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants