Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSD-1611: better error message for NewsletterSignup #1527

Merged
merged 2 commits into from
Feb 21, 2024
Merged

DSD-1611: better error message for NewsletterSignup #1527

merged 2 commits into from
Feb 21, 2024

Conversation

bigfishdesign13
Copy link
Collaborator

Fixes JIRA ticket DSD-1611

This PR does the following:

  • Updates the NewsletterSignup component to follow NYPL recommendations and use more direct language for the email field error message.

How has this been tested?

  • local Storybook

Accessibility concerns or updates

  • n/a

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@vercel Vercel
Copy link

vercel bot commented Feb 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 8:51pm

@bigfishdesign13 bigfishdesign13 added the Needs Review Pull requests that are ready for peer review. label Feb 20, 2024
EdwinGuzman
EdwinGuzman approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should something similar be added to FeedbackBox? Or SearchBar?

@bigfishdesign13 bigfishdesign13 added Ship It Pull requests that have been reviewed and approved. and removed Needs Review Pull requests that are ready for peer review. labels Feb 21, 2024
@bigfishdesign13 bigfishdesign13 merged commit 5d32433 into react18-and-chakra Feb 21, 2024
5 checks passed
@bigfishdesign13 bigfishdesign13 deleted the DSD-1611/newslettersignup-better-errors branch February 21, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdwinGuzman EdwinGuzman EdwinGuzman approved these changes

@7emansell 7emansell Awaiting requested review from 7emansell

@jackiequach jackiequach Awaiting requested review from jackiequach

@oliviawongnyc oliviawongnyc Awaiting requested review from oliviawongnyc

Assignees
No one assigned
Labels
Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigfishdesign13 @EdwinGuzman