DSD-1337: Update Tabs mobile view #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EdwinGuzman
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
This is fantastic and works so much better than my previous implementation. Thanks for this update!
Approving but check with Clare for accessibility, just want to make sure that the "scroll" text in the prev/next buttons is appropriate since this is more of focusing/moving to the next tab.
| @@ -13,8 +13,6 @@ import React, { forwardRef, useState } from "react"; | |||
|
|
|||
| import Button from "../Button/Button"; | |||
| import Icon from "../Icons/Icon"; | |||
| import useCarouselStyles from "../../hooks/useCarouselStyles"; | |||
There was a problem hiding this comment.
Can you update src/hooks/useCarouselStyles.mdx and remove the references to the Tabs component and the code snippet?
This was the only component using this so I think we can do without this hook, but that can be an update for the future.
bigfishdesign13
approved these changes
Feb 28, 2024
bigfishdesign13
added
the
Ship It
EdwinGuzman
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIRA ticket DSD-1337
This PR does the following:
How has this been tested?
Accessibility concerns or updates
Checklist:
Front End Review: