DSD-1623: label spacing for DatePicker, Select, Slider, and TextInput #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bigfishdesign13
requested review from
EdwinGuzman,
jackiequach,
oliviawongnyc and
7emansell
bigfishdesign13
added
the
Needs Review
EdwinGuzman
reviewed
Mar 22, 2024
EdwinGuzman
reviewed
Mar 22, 2024
| @@ -125,6 +125,10 @@ const labelLegendText = { | |||
| color: "dark.ui.typography.heading", | |||
| }, | |||
| }; | |||
| // Used in form inputs that require nuanced spacing. | |||
| const labelLegendTextSpecialSpacing = { | |||
| marginBottom: "xxxs", | |||
There was a problem hiding this comment.
Why not add this rule to fieldset.ts and label.ts? This seems like it'll be easier to miss if the update is in the component file than the style file.
There was a problem hiding this comment.
I was following the pattern of labelLegendText because I wanted a reusable object.
There was a problem hiding this comment.
Yes, but labelLegendText is used in fieldset.ts and label.ts and not in the __css prop for the components. So what's here is fine but if we can keep the update in the theme files, that'd be ideal.
EdwinGuzman
approved these changes
Mar 29, 2024
EdwinGuzman
reviewed
Apr 1, 2024
src/theme/components/datePicker.ts
Outdated
|
|
||
| const DatePicker = defineMultiStyleConfig({ | ||
| baseStyle: definePartsStyle({ | ||
| fieldset: { | ||
| legend: { ...labelLegendTextSpecialSpacing }, |
There was a problem hiding this comment.
This can be legend: labelLegendTextSpecialSpacing,
EdwinGuzman
reviewed
Apr 1, 2024
EdwinGuzman
approved these changes
Apr 1, 2024
bigfishdesign13
removed
the
Needs Review
bigfishdesign13
added
the
Ship It
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIRA ticket DSD-1623
This PR does the following:
DatePicker,Select,Slider, andTextInputcomponents to reduce the spacing between the field label and the field itself from"8px"to"2px".FilterBarandMultiSelectGroupcomponents were not addressed because they have not yet been reintroduced back into the DS.How has this been tested?
Accessibility concerns or updates
Checklist:
Front End Review: