Load bar button item images from the correct bundle #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn’t really belong in the PhotosVC.
|
Does this change make NYTPhotoViewer's minimum version iOS 8 with the usage of imageNamed:inBundle: (which I think is an iOS 8 method)? If so, you may want to change the minimum version in the pod spec also. |
Done in f257274 |
|
@cdzombak needs to be updated now |
Twigz
added a commit
that referenced
this pull request
Oct 30, 2015
Load bar button item images from the correct bundle
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this change, I'm using
resource_bundleas recommended by CocoaPods.After cutting a new version, this: