React18 #224
Merged
React18 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: set node version with nvm
…rk, commented out sessionID functionality
…nts, so a wrapper function has been created on wholeApp to be able to pass params . WholeAppWithParams . PROBLEM it seems that the save function dont work on firestore , I need to check uot what the problem is
…om url in index.js and passing it as a prop to WholeApp
…-|- App uses new React18 createRoot -|- MusicalStaff: Accidental,StaveNote,Voice,Formatter from vexFlow is moved domethods that uses them. -|- Soundmaker uses @tonejs/piano again -|- wholeApp requires sessionId to be passed as a named prop this is done using the WholeAppWrapper when called from a url route, (the wrapper can be removed if WholeApp is rewritten to a functional component) -|- nvmrc is set to use node gallium (16.*)
… it is implemented
…Scale, noteOnHandler, noteOffHandler
… so I have adjusted the color
…to just chrome, settingsjson added jest.commandline cmd, and fixed deprecated prettier to bracketSameLine
Fixing white color
fixing that LH pc keys don't change root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to use React18