Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 Compatibility #5

Merged
merged 13 commits into from
Oct 16, 2022

Conversation

Cambis
Copy link
Contributor

@Cambis Cambis commented Oct 13, 2022

What's new?

  • PHP 8.x
  • Coding standards
  • PHPUnit 9.5.x

ishannz and others added 12 commits May 19, 2018 08:27
Fix constraint to be compat with recipe-blog 1.0.0
- Bump phpunit to 9.x
- Update requiredExtensions to required_extensions
- Update extension to use SiteTree instead of Page, this may cause breaking changes? Page is a descendant of SiteTree so hopefuly not. However, the tests will not pass if Page is used as it will complain that Vote does not have a reference to SiteTree
composer.json Outdated
"silverstripe/comments": "2.1.3@stable"
"colymba/gridfield-bulk-editing-tools": "^3.0",
"silverstripe/cms": "^4.0",
"silverstripe/comments": "^3.1.0@stable",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this constraint just ^3 please?

@NightJar
Copy link
Contributor

NightJar commented Oct 13, 2022

Wow that's noisy, but thanks for merging to master :)
Luckily doing a compare to the other work branch you've included cleans up the diff for review.

@NightJar NightJar merged commit 89f844c into NZTA:master Oct 16, 2022
@NightJar
Copy link
Contributor

Thanks!

@NightJar NightJar mentioned this pull request Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants