Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing old react component to use react hooks #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deveix
Copy link

@deveix deveix commented Mar 29, 2021

I used react v0.63.4 and i found out that this repo needs refactoring to use hooks and lose all outdated component lifecycles.

i don't know if you want to keep it for the users using old react native versions or not you make the decision i just wrote the code that worked for my app.

Thanks in advance.

@deveix deveix force-pushed the react-0.95-update branch 4 times, most recently from f5b5d3c to 3c6aac4 Compare March 29, 2021 21:05
Copy link

@naderalfakesh naderalfakesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your file formatter is using tabs but the original repo files are using 2 spaces.
Maybe changing to that for this PR will reduce the amount of changes to its gist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants