Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging tab to create new window - new window has sidebery closed and "open sidebar" error message #92

Open
nirurin opened this issue Jul 17, 2024 · 20 comments
Labels
bug Something isn't working firefox bug Bug of Firefox, not of ShyFox Sidebery Sidebery related issue

Comments

@nirurin
Copy link

nirurin commented Jul 17, 2024

Dragging a tab out of the tab bar causes a new window to open, which is standard sidebery behaviour. The problem is that when it happens, the new window has a blank sidebar panel with the red "open sidebar" error message showing. In order to get sidebery back, I have to manually toggle sidebery back on.

This is not a sidebery or firefox issue, as I have tested this on other browser instances (without shyfox) as well as on Floorp, and the new tab windows open as normal and sidebery is still open in the new window sidebar.

I have also noticed that after the new windows is made, a new bug appears (which may or may not be related, but I assume it's related). When you hover over a tab, and the popup thumbnail appears, it is no longer the default popup overlay but instead it falls back to the 'popup in window' version which uses a small window frame. And in that window frame, I can see a big red "open sidebar" error message!

Screenshot 2024-07-17 055245

@Naezr
Copy link
Owner

Naezr commented Jul 17, 2024

Dragging a tab out of the tab bar causes a new window to open, which is standard sidebery behaviour. The problem is that when it happens, the new window has a blank sidebar panel with the red "open sidebar" error message showing. In order to get sidebery back, I have to manually toggle sidebery back on.

Maybe issue with your current profile
https://support.mozilla.org/en-US/questions/1342740

And in that window frame, I can see a big red "open sidebar" error message!

I don't use such a preview myself, for my system centers all new windows. I don't use previews at all, btw. I will try to make sure that nothing unnecessary is displayed there.

Try to use different preview methods, window mode is experimental
изображение

@Naezr Naezr added bug Something isn't working firefox bug Bug of Firefox, not of ShyFox Sidebery Sidebery related issue labels Jul 17, 2024
@nirurin
Copy link
Author

nirurin commented Jul 17, 2024 via email

@Naezr
Copy link
Owner

Naezr commented Jul 17, 2024

Popup mode doesn't work very well either. If you hide the sidebar, then when you hover over it, those previews will overlap with the sidebar. For now, I recommend disabling the previews completely.

I may be able to modify the "in sidebar after the tab" mode so that it doesn't change the height of the tab, but create a popup inside the sidebar.

@Naezr
Copy link
Owner

Naezr commented Jul 17, 2024

The short answer is no. “in sidebar after the tab” preview seems almost impossible to style. At least it didn't work for me. And by default they look weird and push all the other tabs down. Window previews work crookedly and are experimental. Previews on the page are overlapped by the sidebar if autohide is enabled.

I haven't used previews before and don't intend to later. I'm more comfortable renaming tabs if I have a lot of them

@TetraKarma
Copy link

TetraKarma commented Jul 17, 2024

Maybe issue with your current profile https://support.mozilla.org/en-US/questions/1342740

I tried the fix suggested, but the problem 'open sidebar' still persists.
xulstore.json is also recreated after a few moments on firefox startup.

(note, I haven't tried sidebery without shyfox, so I can not confirm which one is causing this behavior)

@Naezr
Copy link
Owner

Naezr commented Jul 18, 2024

Do I understand correctly that you drag a tab from Sidebery to the outside, it opens in a new window and in that window sidebar doesn't open automatically?

I'm not sure if css styles can have any effect on the logic of opening the sidebar. Don't confuse it with toggles, by browser logic the sidebar is always open/active/running.

Try removing the theme. Rename the chrome folder to chrome1 or something like that. See how it behaves that way

@TetraKarma
Copy link

The issue occurs when i open a new window or open the tab in a new window (I am running on arch).

Try removing the theme. Rename the chrome folder to chrome1 or something like that. See how it behaves that way

Sidebery doesn't launch automatically for subsequent instances of firefox. Thank you for the suggestion, it seems sidebery doesn't launch automatically on new windows

@Naezr
Copy link
Owner

Naezr commented Jul 18, 2024

How it works for me:

2024-07-18.13-08-00.webm

Since ShyFox is not involved in this problem, there is nothing I can do to help

@nirurin
Copy link
Author

nirurin commented Jul 18, 2024

What version of firefox are you running?

Seems odd that sideberry opens for you, but it doesn't for me or other users. I posted this question on reddit to see if someone might have a fix and people seemed to think its a firefox or sidebery bug (which is valid) but if that was the case you should -also- be having the same behaviour.

That it works for you, means you have something running that fixes the issue.

Edit: I am currently running it on the basic 128 stable release. Are you on beta or nightly?

Edit2: You can see in your example that it opens to the 'open sidebar' red error message, but then it automatically opens up sidebery. For everyone else the sidebery step isn't happening (I'd have to press the manual button to reopen it).

@Naezr
Copy link
Owner

Naezr commented Jul 19, 2024

I'm using the flatpak release of Firefox for Linux. Version 128 at the moment.

I decided to check on my Windows virtual machine and it turns out that there the sidebar really doesn't open in new windows created by drag-n-dropping tab.

After that I decided to try it on a clean profile on my Linux. Here too, the sidebar does not open automatically. Sidebar opens when creating a new window manually, but does not open when drag-n-dropping a tab from Sidebery. That's weird. Maybe there is some old setting in my profile that has changed its default value. I didn't customize anything for it. However, my profile is quite old and has gone through many updates

@nirurin
Copy link
Author

nirurin commented Jul 19, 2024

I'm using the flatpak release of Firefox for Linux. Version 128 at the moment.

I decided to check on my Windows virtual machine and it turns out that there the sidebar really doesn't open in new windows created by drag-n-dropping tab.

After that I decided to try it on a clean profile on my Linux. Here too, the sidebar does not open automatically. Sidebar opens when creating a new window manually, but does not open when drag-n-dropping a tab from Sidebery. That's weird. Maybe there is some old setting in my profile that has changed its default value. I didn't customize anything for it. However, my profile is quite old and has gone through many updates

Interesting. Would seem to imply that there's a bug introduced in the current css setup somewhere. Hopefully it's possible to narrow it down!

@Naezr
Copy link
Owner

Naezr commented Jul 19, 2024

I'm 99% sure css has nothing to do with it. I also checked without ShyFox, on pure Firefox and Sidebery. Maybe there is some setting for about:config that is responsible for this

@nirurin
Copy link
Author

nirurin commented Jul 20, 2024

I've had the report up on the sidebery gitthub for a couple days, but I've noticed that the dev there hasn't actually responded to or fixed any bugs for maybe 6 months or more. Seems like there might be a couple contributors trying to keep the lights on but there are pages of unanswered bug reports.

Just for the sake of finding an alternate solution, I'm going to try a different vertical tabs solution, probably 'tree style tabs'. Hopefully it doesnt cause issues with shyfox!

@nirurin
Copy link
Author

nirurin commented Jul 20, 2024

No immediate issues, but it also has the same behaviour of the sidebar not loading on a new window created via an existing tab. So it seems unlikely that sideberry is the problem either.

@karamanliev
Copy link

I too am experiencing the same problem. Removing xulstore.json didn't help. Using latest firefox from the arch linuxrepositories.

@themegaxandy
Copy link

I use Windows, and this functionality used to work, but now it doesn't work as it should. I don't know if this problem started with an update to Firefox, Sideberry or even ShyFox, it's hard to say. But alternatively, I added an option in Sideberry to move a tab to another new or existing window when right-clicking.

image

@ilsubyeega
Copy link

Can someone reproduce this issue at 129.0.2 now? it seems to fixed for me.

@themegaxandy
Copy link

The drag tab to create a new window seems to be fixed after the Firefox update for me as well. The "open sidebar" issue still persists though.

@Naezr
Copy link
Owner

Naezr commented Aug 23, 2024

Can someone reproduce this issue at 129.0.2 now? it seems to fixed for me.

Yes, I can confirm it's fixed

@Naezr
Copy link
Owner

Naezr commented Aug 23, 2024

The "open sidebar" issue still persists though.

I thought it was some special setting left in my very old Firefox profile. But recently I cleaned up my profile folder and on a newly customized clean profile the sidebar opens by itself.

It's possible that this setting is affecting it:
image
If so, the solution lay on the surface. If not, I don't know what to do, it's some stupid bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firefox bug Bug of Firefox, not of ShyFox Sidebery Sidebery related issue
Projects
None yet
Development

No branches or pull requests

6 participants