fix: disable use_bool_op
in objective c (#32)
#63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Naios
What was a problem?
See #32
How this PR fixes the problem?
This PR disables
use_bool_op
when Objective C is detected.I would appreciate some help to to update this PR to a more robust implementation though.
I've written a small POC that adds an additional check to
has_bool_op
that fails when the given type is convertible to a block-pointer: https://godbolt.org/z/GhM63xYndThe implementation seen above is not implemented in this PR as I've used std::function to deduce the return and parameter types. I tried to do this with the
function_trait
found in the library, however, it does not seem to cover lambdas ootb, so I figured I might ask here first before modifyingfunction_trait
.Check lists (check
x
in[ ]
of list items)