Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sqlite for bundle #877

Merged
merged 16 commits into from
Jul 2, 2024
Merged

Use sqlite for bundle #877

merged 16 commits into from
Jul 2, 2024

Conversation

namse
Copy link
Contributor

@namse namse commented Jun 28, 2024

Use sqlite for bundle will make a big performance improvement for windows(https://www.sqlite.org/fasterthanfs.html), and also I'd like to change bundle system in wasi more simple with sqlite.

Windows not tested.
Wasi tested.

Breaking changes: no bundle: for bundle url.

// before
let buffer = namui::system::file::bundle::read("bundle:resources/text.txt");

// after
let buffer = namui::system::file::bundle::read("resources/text.txt");

@namse namse added namui This issue is for namui engine namui-cli labels Jun 28, 2024
@namse namse requested a review from bigfoodK June 28, 2024 17:33
@namse namse self-assigned this Jun 28, 2024
@namse
Copy link
Contributor Author

namse commented Jun 28, 2024

@bigfoodK Could you make it work on windows?

@bigfoodK bigfoodK self-requested a review June 29, 2024 01:21
@NamseEnt NamseEnt locked and limited conversation to collaborators Jun 29, 2024
@NamseEnt NamseEnt unlocked this conversation Jun 29, 2024
@namse namse enabled auto-merge (squash) July 1, 2024 15:44
@namse namse merged commit 72c28a7 into master Jul 2, 2024
30 checks passed
@namse namse deleted the namui/bundle-sqlite2 branch July 2, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
namui This issue is for namui engine namui-cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants