This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Add destructor to RequestStream #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbarua
force-pushed
the
master
branch
2 times, most recently
from
5afcc63
to
a9b6fa1
Compare
| @@ -195,12 +200,14 @@ public override IAsyncResult BeginWrite(byte[] buffer, int offset, int count, As | |||
| { | |||
| return this.stream.BeginWrite(buffer, offset, count, callback, state); | |||
| } | |||
|
|
|||
…emp files if .Dispose() not explicitly called.
danbarua
added a commit
to danbarua/Nancy
that referenced
this pull request
Apr 26, 2016
…emp files if .Dispose() not explicitly called. (NancyFx#2430) # Conflicts: # src/Nancy/IO/RequestStream.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Given a large (>85kb) request
When
.Dispose()is not explicitly called (exception?)Then we leak temp files
Reports from ops that it is leaking one temp file for every upload that throws an exception.
Related to #2159