Some optimizations #1052
Merged
Some optimizations #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added method `stringNotEmpty` to replace lambdas in `ConfigItem`s' `restrictions` with 2. Made `proxy` a property, in which `proxyAddress` would be checked (adding scheme, returning None if not legal, etc.)
Added lines to set `proxy` and `verify` of `PixivOAuthBrowser` with given parameters when initializing `PixivOAuth` objects.
1. Added a global variable `session` for requests 2. Added methods `set_proxy` and `set_verify` to set `proxies` and `verify` of the `session` 3. Changed requests made with `requests` to `session`
|
I didn't put cases where a user uses proxies with domains instead of ips into consideration... |
Nandaka
reviewed
Nov 18, 2021
PixivConfig.py
Outdated
| value = getattr(self, "proxyAddress", None) | ||
| if not value: | ||
| return None | ||
| match = re.match(r"^(?:(http|socks[45])://)?(\d+\.\d+\.\d+\.\d+):(\d+)$", value) |
There was a problem hiding this comment.
maybe can use this pattern ^(https|http|socks[45])://[\w.]+(:?\d*)$
There was a problem hiding this comment.
updated to allow - = ^(https|http|socks[45])://[\w.-]+(:?\d*)$
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details please refer to each commits.