Coinbase Api #119
Merged
Coinbase Api #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenchcooc
suggested changes
Oct 5, 2020
Frenchcooc
reviewed
Oct 5, 2020
integrations/coinbase.json
Outdated
| "authorizationParams": { "response_type": "code" } | ||
| }, | ||
| "request": { | ||
| "baseURL": "https://api.coinbase.com/v2/user", |
There was a problem hiding this comment.
Suggested change
| "baseURL": "https://api.coinbase.com/v2/user", | |
| "baseURL": "https://api.coinbase.com/v2/", |
There was a problem hiding this comment.
but according to doc we have a value /user at end of the url, right? why is it ok to omit it?
There was a problem hiding this comment.
As far as I can tell, the Coinbase API has two different endpoints:
The baseURL should be the common part of these endpoints. Otherwise, only the /user endpoint would be accessible using Pizzly with the previous configuration.
|
please add 'hacktoberfest-accepted' label to pr and merge. thanks :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Coinbase API.
Types of changes
What types of changes does your code introduce to Appium?