-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coinbase Api #119
Coinbase Api #119
Conversation
integrations/coinbase.json
Outdated
"authorizationParams": { "response_type": "code" } | ||
}, | ||
"request": { | ||
"baseURL": "https://api.coinbase.com/v2/user", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"baseURL": "https://api.coinbase.com/v2/user", | |
"baseURL": "https://api.coinbase.com/v2/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but according to doc we have a value /user at end of the url, right? why is it ok to omit it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, the Coinbase API has two different endpoints:
The baseURL
should be the common part of these endpoints. Otherwise, only the /user
endpoint would be accessible using Pizzly with the previous configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
please add 'hacktoberfest-accepted' label to pr and merge. thanks :)) |
Proposed changes
Coinbase API.
Types of changes
What types of changes does your code introduce to Appium?