fix(reporting): add error in datadog APM #1615
Conversation
| @@ -27,7 +27,7 @@ | |||
| "@trpc/client": "^10.44.1", | |||
| "@trpc/server": "^10.44.1", | |||
| "@types/fs-extra": "^11.0.1", | |||
| "dd-trace": "4.20.0", | |||
| "dd-trace": "5.2.0", | |||
There was a problem hiding this comment.
Upgrading all the packages because they changed the types (the main breaking change was the drop of Node16)
| @@ -46,7 +47,7 @@ class ErrorManager { | |||
| } | |||
| } | |||
|
|
|||
| public async report(e: any, config: ErrorOptionalConfig = { source: ErrorSourceEnum.PLATFORM }) { | |||
| public report(e: unknown, config: ErrorOptionalConfig = { source: ErrorSourceEnum.PLATFORM }, tracer?: Tracer): void { | |||
There was a problem hiding this comment.
I had to pass the tracer around because the report mechanism is used at very different places. Let me know if you think of another way to log to the span, but I think it's handy and could be reused inside the runner or persist.
There was a problem hiding this comment.
I think it is fine. There is definitely a lot of room for improvements wrt how we do error handling in general and across services
| @@ -46,7 +47,7 @@ class ErrorManager { | |||
| } | |||
| } | |||
|
|
|||
| public async report(e: any, config: ErrorOptionalConfig = { source: ErrorSourceEnum.PLATFORM }) { | |||
| public report(e: unknown, config: ErrorOptionalConfig = { source: ErrorSourceEnum.PLATFORM }, tracer?: Tracer): void { | |||
There was a problem hiding this comment.
I think it is fine. There is definitely a lot of room for improvements wrt how we do error handling in general and across services
Describe your changes
Adding error in datadog APM automatically.
Because of a "bug" in dd-trace, the errors are not reported automatically when used in express (cf: DataDog/dd-trace-js#1944)
To resolve that we can tag the error manually.
Issue ticket number and link
Fixes NAN-320
Checklist before requesting a review
Examples