fix(oauth2_cc): add necessary parameters when creating connection #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hassan254-prog
commented
Jun 17, 2024
| @@ -788,7 +788,7 @@ class ConnectionService { | |||
|
|
|||
| const oauth2Creds: OAuth2ClientCredentials = { | |||
| type: 'OAUTH2_CC', | |||
| token: rawCreds['token'], | |||
| token: rawCreds['access_token'] || rawCreds['data']['token'], | |||
There was a problem hiding this comment.
To ensure that personio does not break for other users.
|
Will try and test this tomorrow to make sure nothing breaks with these changes |
khaliqgant
approved these changes
Jun 24, 2024
khaliqgant
pushed a commit
that referenced
this pull request
Jun 24, 2024
## Describe your changes Add support for various `oauth2_cc` providers, to further test [2345](#2345) - Ory - Cloudentity - Twitter - Spotify ## Issue ticket number and link ## Checklist before requesting a review (skip if just adding/editing APIs & templates) - [ ] I added tests, otherwise the reason is: - [ ] I added observability, otherwise the reason is: - [ ] I added analytics, otherwise the reason is:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add necessary parameters for generating and refreshing an access_token in
oauth2_cc.Issue ticket number and link
Checklist before requesting a review (skip if just adding/editing APIs & templates)