fix(sdk): sample record validation errors #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaliqgant
approved these changes
Oct 1, 2024
TBonnin
reviewed
Oct 1, 2024
| metrics.increment(metrics.Types.RUNNER_INVALID_SYNCS_RECORDS); | ||
|
|
||
| if (this.runnerFlags?.validateSyncRecords) { | ||
| break; | ||
| } |
There was a problem hiding this comment.
early break if enabled
There was a problem hiding this comment.
otherwise it just logs everything*
There was a problem hiding this comment.
hasErrors is never gonna have more than 1 element then if we always early break
There was a problem hiding this comment.
yes sorry it's maybe not clear, this flag is only set to true in CLI
There was a problem hiding this comment.
ah ok. so in CLI it breaks out after the first validation error
TBonnin
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes https://linear.app/nango/issue/NAN-1833/reduce-validation-logs-andor-process-in-parallel
Sample record validation errors
It's spamming the infra, making syncs slower than they should be.
Send the sample in parallel
Don't remember why I didn't do it like this. It complexifies the code a bit but faster; since we sample it's no longer a big problem but can be useful if we increase the sampling or remove it.