Prepare for 1.20 release #1723
Merged
Prepare for 1.20 release #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ahoenselaar
reviewed
Aug 11, 2021
| * meep.BoundarySteppingPE ("boundary stepping PE") | ||
| * meep.BoundarySteppingE ("boundary stepping E") | ||
| * meep.Other ("everything else") | ||
| can be one of the following integer constants: `0`: "time stepping", `1`: "connecting chunks", |
There was a problem hiding this comment.
Why do we use these integer values here instead of the enum?
There was a problem hiding this comment.
Two reasons: (1) integer values for the indices of the timing stack was the way this was originally documented and (2) for convenience, since the enums sometimes have too many characters to type out.
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* Prepare for 1.20 release * remove nightly built Conda package from the installation page * update description for subpixel smoothing of MaterialGrid * bump 1.20.0 date, update links * whoops * version bump Co-authored-by: Steven G. Johnson <stevenj@alum.mit.edu>
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
* Prepare for 1.20 release * remove nightly built Conda package from the installation page * update description for subpixel smoothing of MaterialGrid * bump 1.20.0 date, update links * whoops * version bump Co-authored-by: Steven G. Johnson <stevenj@alum.mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some minor improvements to the docs.