Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Moved settings save&get to KOT #1670

Merged
merged 4 commits into from
Jun 29, 2023
Merged

lib: Moved settings save&get to KOT #1670

merged 4 commits into from
Jun 29, 2023

Conversation

onuratakan
Copy link
Member

Why ?

Closes #1661

Checking

  • No personal details (pass and etc.)

@viezly
Copy link

viezly bot commented Jun 29, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@restyled-io restyled-io bot deployed to LINT Tests June 29, 2023 02:16 Active
@restyled-io restyled-io bot deployed to UNIT Tests June 29, 2023 02:17 Active
@restyled-io restyled-io bot deployed to UNIT Tests June 29, 2023 02:17 Active
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #1670 (985c56c) into master (d65df36) will decrease coverage by 2.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1670      +/-   ##
==========================================
- Coverage   97.91%   95.65%   -2.26%     
==========================================
  Files         133      134       +1     
  Lines       10665    11035     +370     
==========================================
+ Hits        10443    10556     +113     
- Misses        222      479     +257     
Flag Coverage Δ
unittests 95.65% <100.00%> (-2.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
naruno/lib/settings_system.py 85.00% <100.00%> (-0.25%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@onuratakan onuratakan merged commit c34c8be into master Jun 29, 2023
41 of 50 checks passed
@onuratakan onuratakan deleted the 1661 branch June 29, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lib: Moving settings save&get to KOT
2 participants