-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to sign files in naruno/lib/sign.py #1742
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to sign files in the
naruno/lib/sign.py
file. It modifies the existingsign
function to check if thedata
parameter is a file. If it is, the function reads the file and converts it to a string before proceeding with the existing logic. This allows users to sign files without adding a new parameter, utilizing the existingdata
parameter.Additionally, the
verify
function in thenaruno/lib/verify.py
file has been modified to handle file signatures. If thepath
parameter points to a file, the function reads the file and loads the contents as thesign_json
variable. This ensures that theverify
function can handle both regular signatures and file signatures.Summary of Changes
sign
function innaruno/lib/sign.py
to handle file signatures by checking if thedata
parameter is a file and converting it to a string if necessary.verify
function innaruno/lib/verify.py
to handle file signatures by reading the file contents if thepath
parameter points to a file.Please review and merge this PR. Thank you!
Fixes #1729.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.