Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authorization rules #12

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Add authorization rules #12

merged 5 commits into from
Aug 31, 2023

Conversation

Nasirkhan294
Copy link
Owner

In this milestone we:

Installed CanCanCan gem.

  • Added a role column to the users' table.
  • A user can delete a post if it is theirs or if they have an admin role (column role has value "admin"). Used CanCanCan for this authorization.
    • Implemented the post-deleting functionality. Added the "Delete" button to the view and make sure that only authorized users can see it.
  • A user can delete a comment if it is theirs or if they have an admin role (column role has value "admin"). Used CanCanCan for this authorization.
    • Implemented the comment-deleting functionality. Added the "Delete" button to the view and make sure that only authorized users can see it.

Copy link

@joskalenda joskalenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED ✅
Hi @Nasirkhan294 , 🥰
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

✅ ... Good commit messages
✅ ... Clean authorization


Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏


Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me(@joskalenda) in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Nasirkhan294 Nasirkhan294 merged commit e83cd39 into dev Aug 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants