Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 support #770

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Drop Python 3.8 support #770

merged 3 commits into from
Feb 26, 2024

Conversation

juhoinkinen
Copy link
Member

@juhoinkinen juhoinkinen commented Feb 23, 2024

I started to update dependencies for the next release, but noted that many dependencies cannot be upgraded for Python 3.8, so it seems to best to drop it out the Python versions that Annif supports (after this 3.8-3.11). This is in line with the Backward compatibility policy.

In the CI/CD pipeline the Python versions used in different actions are rotated forward.

Also removes the tensorflow-io-gcs-filesystem dependency, which was recently added in #759 to fix installing Annif on Python 3.8.

@juhoinkinen juhoinkinen added this to the 1.1 milestone Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.29%. Comparing base (f467aa4) to head (ec7b79a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
- Coverage   99.67%   99.29%   -0.38%     
==========================================
  Files          89       89              
  Lines        6404     6404              
==========================================
- Hits         6383     6359      -24     
- Misses         21       45      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juhoinkinen juhoinkinen marked this pull request as ready for review February 26, 2024 12:04
@juhoinkinen juhoinkinen merged commit 1e182b2 into main Feb 26, 2024
15 of 16 checks passed
@juhoinkinen juhoinkinen deleted the drop-python-3.8-support branch February 26, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants