Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non Unique sort keys in qroHeader() title elements. #111

Closed
NathanGibbs3 opened this issue Jul 19, 2021 · 0 comments
Closed

Non Unique sort keys in qroHeader() title elements. #111

NathanGibbs3 opened this issue Jul 19, 2021 · 0 comments
Assignees
@NathanGibbs3
Labels
bug Something isn't working invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. Stability Issue impacts or is related to App Stability.
Milestone
1.4.6

Comments

@NathanGibbs3
Copy link
Owner

Item Description
File: includes/base_output_query.inc.php
Class: QueryResultsOutput
Function: AddTitle() & GetSortSQL()
Similar Issues: #22
Depends on Issue(s): N/A
Dependency Type: N/A
Misc. Info.: The code is assuming that the caller of AddTitle() will assure property uniqueness across multiple title elements. Breaking this assumption can lead to bugs when GetSortSQL()is called. The first matching property is returned regardless of which title it is in.

Expected Behavior:
Each title element is given unique sort properties that can later be retrieved in a caller agnostic way.
Current Behavior:
The $asc_sort & $desc_sort properties of qroHeader title elements are not unique across title elements.
@NathanGibbs3 NathanGibbs3 added bug Something isn't working invalid This doesn't seem right Prod Observed in Production Environment. LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. labels Jul 19, 2021
@NathanGibbs3 NathanGibbs3 added this to the 1.4.6 milestone Jul 19, 2021
@NathanGibbs3 NathanGibbs3 self-assigned this Jul 19, 2021
@NathanGibbs3 NathanGibbs3 mentioned this issue Jul 19, 2021
Closed
NathanGibbs3 added a commit that referenced this issue Dec 2, 2021
@NathanGibbs3
20211202 Closes #22 Closes #23 Closes #101 Closes #111 for real this …
ab10b11 
…time! :-)

         Code Cleanup.

     File(s): base_stat_sensor.php
              Issue(s): #22 & #23 Fix
              Code cleanup.
     File(s): includes/base_action.inc.php
              Issue(s): #101 Fix
              Code cleanup.
     File(s): includes/base_output_query.inc.php
              Issue(s): #111 Fix, and this time we mean it! :-)
     File(s): includes/base_state_common.inc.php
 Function(s): CleanVariable()
              Code cleanup.
Unit Test(s): CleanVariable()
@NathanGibbs3 NathanGibbs3 added the Stability Issue impacts or is related to App Stability. label Dec 3, 2021
This was referenced Dec 19, 2021
Closed
Closed
Closed
Closed
@NathanGibbs3 NathanGibbs3 mentioned this issue Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanGibbs3 NathanGibbs3

Labels
bug Something isn't working invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. Stability Issue impacts or is related to App Stability.
Projects
None yet
Milestone
1.4.6
Development

No branches or pull requests
1 participant
@NathanGibbs3