Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL insufficient input validation on Ipv4 addresses. #224

Open
NathanGibbs3 opened this issue Jul 1, 2023 · 0 comments
Open

RTL insufficient input validation on Ipv4 addresses. #224

NathanGibbs3 opened this issue Jul 1, 2023 · 0 comments
Assignees
@NathanGibbs3
Labels
bug Something isn't working invalid This doesn't seem right New-TechDebt Issue caused by previous commit to this repo. We created it. Prod Observed in Production Environment. Stability Issue impacts or is related to App Stability.
Milestone
1.4.6

Comments

@NathanGibbs3
Copy link
Owner

Item Description
File(s): base_rtl.php
Class:
Function: is_ip4()
Similar Issues:
Depends on Issue(s):
Dependency Type:
Misc. Info.: RTL < 0.0.12

Expected Behavior:
Correctly validates input.
Current Behavior:
Returns true for invalid IPv4 addresses.
@NathanGibbs3 NathanGibbs3 added bug Something isn't working invalid This doesn't seem right Prod Observed in Production Environment. New-TechDebt Issue caused by previous commit to this repo. We created it. Stability Issue impacts or is related to App Stability. labels Jul 1, 2023
@NathanGibbs3 NathanGibbs3 added this to the 1.4.6 milestone Jul 1, 2023
@NathanGibbs3 NathanGibbs3 self-assigned this Jul 1, 2023
NathanGibbs3 added a commit that referenced this issue Jul 2, 2023
@NathanGibbs3
20230702 Closes #217 Closes #218 Closes #222 Closes #223
119d8c6 
         Closes #224 Closes #225 Closes #226
         Code Cleanup.

     File(s): base_ag_main.php
            : base_local_rules.php
            : includes/base_krnl.php
            : includes/base_net.inc.php
            : includes/base_state_citems.inc.php
            : includes/base_state_query.inc.php
              Code Cleanup.
     File(s): base_common.php
              Code Cleanup.
    Issue(s): #222
 Function(s): Removed: BuildIPFormVars(), BuildSrcIPFormVars(), &
              BuildDstIPFormVars().
 Function(s): BuildIPFormVar( ip, addr_type, criteria_instance )
              Returns HTTP Query String fragment containing IP
              Address search criteria; or empty string on invalid
              IP.
              Note: Curently the NULL_IP constant is also treated
              as valid foe backward compatibility reasons. This
              "feature" will be removed in the future, when code
              depending on NULL_IP being in the HTTP Query String
              is removed.
     File(s): base_db_common.php
            : includes/base_db.inc.php
              Code Cleanup.
    Issue(s): #226
     File(s): base_maintenance.php
            : composer.json
            : includes/base_auth.inc.php
            : includes/base_capabilities.php
              Code Cleanup.
    Issue(s): #225
     File(s): base_stat_ipaddr.php
    Issue(s): #217
              Code Cleanup.
     File(s): base_stat_uaddr.php
    Issue(s): #223
              Code Cleanup.
     File(s): includes/base_log_error.inc.php
    Issue(s): #226
 Function(s): returnBuildError( Desc, Opt, dll )
              Added dll paramater to provide more
              meaningful error reports for Windows
              installations.
     File(s): includes/base_rtl.php
              Code Cleanup.
              Bumped RTL Version to 0.0.12
    Issue(s): #224 #225
 Function(s): BCMi()
              Returns true if BCMath is installed, false otherwise.
            : GMPi()
              Returns true if GMP is installed, false otherwise.
            : IPv6i()
              Returns true if RTL can handle IPv6 on this installation.
              Sets New Constant BASE_RTL_IPv6 accordingly.
     File(s): includes/base_state_criteria.inc.php
    Issue(s): #218
Unit Test(s): Covers BuildIPFormVar(), the following in the
              CriteriaState Class, ReadState().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanGibbs3 NathanGibbs3

Labels
bug Something isn't working invalid This doesn't seem right New-TechDebt Issue caused by previous commit to this repo. We created it. Prod Observed in Production Environment. Stability Issue impacts or is related to App Stability.
Projects
None yet
Milestone
1.4.6
Development

No branches or pull requests
1 participant
@NathanGibbs3