Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showcase: infinite loop for non existing subpaths caused by redirection logic in 404.html on gh-pages branch #1058

Closed
christophercr opened this issue Jan 21, 2019 · 2 comments

Comments

@christophercr
Copy link
Collaborator

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

The app gets stuck in a loop when you type in the location bar a subpath that does not exist. (eg: https://stark.nbb.be/showcase/asdf/)

Expected behavior

The app should always redirect to the homepage in case of an invalid/non-existent path.

Minimal reproduction of the problem with instructions

Open this page: https://stark.nbb.be/showcase/asdf

What is the motivation / use case for changing the behavior?

Environment


Stark version: 10.0.0-beta.2

@christophercr
Copy link
Collaborator Author

christophercr commented Jan 25, 2019

There is also an issue when we go to an non-existing path in the API docs, for example: https://stark.nbb.be/api-docs/stark-ui/latest/components/whatever.html. In such case we are redirected to https://stark.nbb.be/showcase/latest/otherwise 😞

In this case we should be redirected to https://stark.nbb.be/api-docs/stark-ui/latest/

@Mallikki Mallikki self-assigned this Jan 31, 2019
@christophercr
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants