Update 'fatal' log message to be a single call #154
Conversation
| logger.error("##### # # # # # # "); | ||
| logger.error("# ####### # ####### # "); | ||
| logger.error("# # # # # # # "); | ||
| logger.error("# # # # # # #######"); | ||
| logger.error("Fatal Thread Error on " + thread.getName() + " had an uncaught exception", throwable); |
There was a problem hiding this comment.
If we want this message to have greater cosmetic visibility, this could still use a multi-line message ("i.e., "####################\nFatal Thread Error on ..."), but otherwise this looks good.
There was a problem hiding this comment.
That would certainly avoid the multiple logger calls which is the main issue, but the secondary objectives are to make it human readable and make it consumable downstream w/ log analysis tools. Changing the level to FATAL could achieve this as well, but I'm ok with the simplicity here and leaving it ERROR.
This should be convertible to parameterized logging. That would be my only ask. Bonus points for fixing both log statements.
There was a problem hiding this comment.
Added parameterized logging for both log statements in the most recent change
| logger.error("##### # # # # # # "); | ||
| logger.error("# ####### # ####### # "); | ||
| logger.error("# # # # # # # "); | ||
| logger.error("# # # # # # #######"); | ||
| logger.error("Fatal Thread Error on " + thread.getName() + " had an uncaught exception", throwable); |
There was a problem hiding this comment.
That would certainly avoid the multiple logger calls which is the main issue, but the secondary objectives are to make it human readable and make it consumable downstream w/ log analysis tools. Changing the level to FATAL could achieve this as well, but I'm ok with the simplicity here and leaving it ERROR.
This should be convertible to parameterized logging. That would be my only ask. Bonus points for fixing both log statements.
arp-0984
force-pushed
the
update-fatal-message
branch
from
a651cc3
to
6f17e43
Compare
| logger.error("# # # # # # # "); | ||
| logger.error("# # # # # # #######"); | ||
| logger.error("Fatal Thread Error on " + thread.getName() + " had an uncaught exception", throwable); | ||
| logger.error("Fatal Thread Error on {} had an uncaught exception {}", thread.getName(), throwable); |
There was a problem hiding this comment.
The second set of {}'s can be dropped. The exception will be handled naturally w/o replacement as long as it's the last parameter provided.
There was a problem hiding this comment.
Removed the second set of {}'s
arp-0984
force-pushed
the
update-fatal-message
branch
from
6f17e43
to
78d9097
Compare
No description provided.