Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding ability to pull from different directories for test data & answer files #783

Merged
merged 4 commits into from
May 23, 2024
Merged

adding ability to pull from different directories for test data & answer files #783

merged 4 commits into from
May 23, 2024

Conversation

sambish5
Copy link
Collaborator

creates getMyTestAnswerFiles, which allows for test answer files from one directory to work with data files from another directory.

@sambish5 sambish5 requested review from jpdahlke and dev-mlb May 20, 2024 13:17
@ldhardy ldhardy self-requested a review May 20, 2024 15:11
@sambish5 sambish5 requested a review from dev-mlb May 20, 2024 16:29
@sambish5 sambish5 added the integration A breaking change where effort will be required downstream to resolve label May 20, 2024
@sambish5 sambish5 added enhancement An enhancement or update to an existing feature test-only The change only impacts test code labels May 20, 2024
ldhardy
ldhardy reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@ldhardy ldhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked well when I tried it out. It will make it harder to track what is being tested, but I think that is outweighed by not having so many copy-pasted dat files and hopefully will encourage testing more permutations of configurations.

dev-mlb
dev-mlb previously approved these changes May 21, 2024
View reviewed changes
@sambish5 sambish5 marked this pull request as ready for review May 21, 2024 13:04
@jpdahlke @fbruton
Update src/test/java/emissary/test/core/junit5/UnitTest.java
3821e13 
Co-authored-by: fbruton <19573915+fbruton@users.noreply.github.com>
@jpdahlke jpdahlke requested review from dev-mlb and fbruton May 23, 2024 12:13
@jpdahlke jpdahlke added this to the v8.3.0 milestone May 23, 2024
@jpdahlke jpdahlke merged commit 54ffd56 into NationalSecurityAgency:main May 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldhardy ldhardy ldhardy left review comments

@fbruton fbruton fbruton approved these changes

@jpdahlke jpdahlke jpdahlke approved these changes

@dev-mlb dev-mlb Awaiting requested review from dev-mlb

Assignees
No one assigned
Labels
enhancement An enhancement or update to an existing feature integration A breaking change where effort will be required downstream to resolve test-only The change only impacts test code
Projects
None yet
Milestone
v8.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sambish5 @jpdahlke @fbruton @dev-mlb @ldhardy