Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2860 Fix errorProne build #819

Merged

Conversation

ldhardy
Copy link
Collaborator

@ldhardy ldhardy commented Jun 13, 2024

Hobble the module encapsulation issue

Exception in thread "main" java.lang.IllegalAccessError: class com.google.errorprone.BaseErrorProneJavaCompiler (in unnamed module @0x6279cee3) cannot access class com.sun.tools.javac.api.BasicJavacTask (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.api to unnamed module @0x6279cee3
        at com.google.errorprone.BaseErrorProneJavaCompiler.addTaskListener(BaseErrorProneJavaCompiler.java:92)
        at com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:34)
        at jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugin(BasicJavacTask.java:255)
        at jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:229)
        at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:292)
        at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:176)
        at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
        at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)

Depend explicitly on the correct version of error_prone_annotations and exclude from transient inclusion.

@ldhardy
Copy link
Collaborator Author

ldhardy commented Jun 13, 2024

I'll fix the whitespace issue - I just needed to get this up to unblock some people who are trying to work errorprone stuff.

pom.xml Show resolved Hide resolved
@jpdahlke jpdahlke added this to the v8.5.0 milestone Jun 17, 2024
@jpdahlke jpdahlke merged commit dc83181 into NationalSecurityAgency:main Jun 17, 2024
13 checks passed
@ldhardy ldhardy deleted the 2860-errorprone-profile-fixes branch October 22, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants