Linux extra condition for electron builder. #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To begin with, thank you so much for your hard work. This is an a fantasticep for the PHP community!
This is not meant to be the final solution, but it solves the problem pointed out at this issue: https://github.com/NativePHP/electron/issues/55
After briefly checking the code, I cou't find any place to trigger the npm post-installation to have the option
--linux
. Due to that, an extra check for the platform was needed for the initial script to copy the binary from Linux folder.The same fix might be needed for Windows.