Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php path in queue command #58

Merged

Conversation

phuclh
Copy link
Contributor

@phuclh phuclh commented Jul 29, 2023

Fix php path in queue command. It is pointing to the directory, not the php binary

@mpociot
Copy link
Member

mpociot commented Jul 29, 2023

Mh...you're probably coming from Windows?
But in any case, there should be a file called php in that directory.

@phuclh
Copy link
Contributor Author

phuclh commented Jul 29, 2023

@mpociot no, I am using Mac. When I run the native:queue command manually, it throws an error: php is a directory.

Btw, how do you make the queue command auto run like scheduler? I saw in the source code that had an env variable to skip the queue. I tried to set it to false but nothing happened.

@Jonnx
Copy link

Jonnx commented Jul 30, 2023

seeing the same error message on a fresh project on mac osx

php artisan native:queue
Starting NativePHP queue worker…
sh: /Users/jonasweigert/Development/Personal/com.cachely.app/vendor/nativephp/electron/src/Commands/../../resources/js/resources/php: is a directory

@mpociot
Copy link
Member

mpociot commented Jul 31, 2023

Ah you're right, this was introduced with Windows support. Thanks!

@mpociot mpociot merged commit 7d1e0bf into NativePHP:main Jul 31, 2023
1 check passed
@phuclh phuclh deleted the patches/fix-php-path-in-queue-command branch July 31, 2023 17:40
@Jonnx
Copy link

Jonnx commented Aug 1, 2023

php artisan native:queue now works with the latest changes and processes queue successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants