Skip to content

fix(webpack): support angular 15.x #10106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 30, 2022

Conversation

lekhmanrus
Copy link
Contributor

Migrated to @angular-devkit/build-angular v15.x.

Please see angular/angular-cli#23936

PR Checklist

What is the current behavior?

babel-loader throws errors when you try building with @angular-devkit/build-angular v15.x.
image

What is the new behavior?

No errors.

@cla-bot cla-bot bot added the cla: yes label Nov 24, 2022
NathanWalker
NathanWalker previously approved these changes Nov 26, 2022
Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make this backwards compatible and check the @angular-devkit/build-angular version. The one in the package.json is a devDependency so our tests work, but in actual projects the version from the project's own package.json is used, and it might not be 15.x.

@lekhmanrus
Copy link
Contributor Author

Thanks @rigor789! 🙂

@nx-cloud
Copy link

nx-cloud bot commented Nov 29, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f6e5971. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@rigor789 rigor789 merged commit f100109 into NativeScript:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants