Skip to content

fix(ios/textview): switch order of _setNativeText and _refreshColor in showText-method #8863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2020
Merged

fix(ios/textview): switch order of _setNativeText and _refreshColor in showText-method #8863

merged 1 commit into from
Sep 20, 2020

Conversation

felixkrautschuk
Copy link
Contributor

fix(ios/textview): switch order of _setNativeText and _refreshColor in showText-method

The color should be refreshed after setting the text to keep the styles.

Fixes #8764

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes #8764 .

…n showText-method

The color should be refreshed after setting the text to keep the styles.

fixes #8764
@cla-bot cla-bot bot added the cla: yes label Sep 18, 2020
@NathanWalker
Copy link
Contributor

Thank you @felixkrautschuk ! If possible and time permitting would be possible to add a sample case to the toolbox app that exemplified the behavior? That way we could try it both ways under some other conditions to ensure no side effects which may need an additional check of sorts.
❤️

@NathanWalker
Copy link
Contributor

Actually that issue provides the repro thanks for that.

@NathanWalker NathanWalker merged commit 313f476 into NativeScript:master Sep 20, 2020
@felixkrautschuk
Copy link
Contributor Author

@NathanWalker sorry, I had no time at the weekend to respond, but glad you've found my demo within the issue-thread and you've merged this.

@felixkrautschuk felixkrautschuk deleted the ios-fix-color-dismisssoftinput branch September 22, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS TextView text-color becomes black when keyboard is dismissed
3 participants