fix(core-android): ActivityIndicator changed transferred its color to other ActivityIndicators of the same page

[CatchABus]

PR Checklist

• The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
• There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
• You have signed the CLA.
• All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
• Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.

What is the current behavior?

Changing color to an ActivityIndicator applies the new color to all other ActivityIndicators in the same page.
That only applies to Android.

What is the new behavior?

Each indicator has independent color by calling mutate() on indicator drawable instance at the creation of view.

Fixes/Closes #9021 .

[farfromrefug]

Wouldn t it be better to mutate only when setting the color? If all your activity indicators use the theme color no need to mutate anythin

[CatchABus]

Wouldn t it be better to mutate only when setting the color? If all your activity indicators use the theme color no need to mutate anythin

That is because an indicator's color can be changed multiple times depending on one's needs, resulting in pointless mutate() calls even though they have no appliance after first call. Initializing it once seemed good to me, but we can change it.

[farfromrefug]

Then mark the indicator as mutated. Oersonnaly as I use theme color for indicators I see that PR as a perf lost. I understand the need but we should do it right and mutate only when needed

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dimitris - Rafail Katsampas.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[CatchABus]

Then mark the indicator as mutated. Oersonnaly as I use theme color for indicators I see that PR as a perf lost. I understand the need but we should do it right and mutate only when needed

You are right! To be honest, I didn't consider theme-based indicators. I just committed few more changes that might make things better.