Skip to content

feat(android): types for API Level 30 and cleanup #9219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2021

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Feb 16, 2021

PR Checklist

What is the current behavior?

API Level 30 was missing. Also the native namespace used for Android/Java typings collided with other usages.

What is the new behavior?

API Level 30 is now included. Also the native namespace used for Android/Java typings no longer collides.

BREAKING CHANGE:

If you were usingnative.Array for any of your own custom plugin typings, you can switch them to androidNative.Array

BEFORE:

public writeAsync(path: string, bytes: native.Array<number>) ...

AFTER:

public writeAsync(path: string, bytes: androidNative.Array<number>) ...

@cla-bot cla-bot bot added the cla: yes label Feb 16, 2021
@NathanWalker
Copy link
Contributor Author

These are currently published on @nativescript/types 7.3.0-rc.0 at moment for anyone that needs them.
It's rc since there's a very small chance the native > androidNative namespace switch could affect plugin developers.

@NathanWalker NathanWalker merged commit ebcc0e2 into master Feb 27, 2021
@NathanWalker NathanWalker deleted the fix/android-typings-cleanup branch February 27, 2021 20:45
NathanWalker added a commit that referenced this pull request Mar 30, 2021
API Level 30 is now included. Also the `native` namespace used for Android/Java typings no longer collides with integrations.

BREAKING CHANGE:

If you were using`native.Array` for any of your own custom plugin typings, you can switch them to `androidNative.Array`

BEFORE:

```
public writeAsync(path: string, bytes: native.Array<number>) ...
```

AFTER:

```
public writeAsync(path: string, bytes: androidNative.Array<number>) ...
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant