Skip to content

feat(core): make font style, weight, scale params optional #9993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

lekhmanrus
Copy link
Contributor

Change font style, weight, scale constructor parameters to optional.
Export FontStyle and FontWeight.

PR Checklist

What is the current behavior?

Creating new font instance requires redundant parameters:

new Font('material-symbols-outlined', 28, 'normal', 'normal')

What is the new behavior?

Style, weight and scale parameters are optional:

new Font('material-symbols-outlined', 28)

@cla-bot cla-bot bot added the cla: yes label Aug 12, 2022
Change font style, weight, scale constructor parameters to optional.
Export `FontStyle` and `FontWeight`.
@lekhmanrus lekhmanrus force-pushed the font-optional-params branch from eb3ab59 to d0b20b0 Compare August 13, 2022 00:21
@lekhmanrus lekhmanrus requested a review from rigor789 August 13, 2022 00:22
@NathanWalker NathanWalker merged commit 4b0c812 into NativeScript:main Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants