Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect font icon size conversion to device pixels. #9910

Merged
merged 4 commits into from
May 18, 2022

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented May 15, 2022

PR Checklist

What is the current behavior?

Since NS 6, font icons used with Image, ActionItem, and few more elements have bad sizing between the 2 platforms.
It seems there's been a mistake since the implementation of this feature and font size is multiplied with display density 'twice'.

What is the new behavior?

Font icons used with Image, ActionItem, and few more elements will have proper size in both platforms.
Note: In iOS, there was a pixel conversion that was wrong and also didn't run so it was dead and was consequently removed.

Fixes #8391.

@cla-bot cla-bot bot added the cla: yes label May 15, 2022
@NathanWalker NathanWalker changed the base branch from master to alpha May 15, 2022 20:15
@CatchABus CatchABus marked this pull request as draft May 15, 2022 21:38
@CatchABus CatchABus marked this pull request as ready for review May 15, 2022 21:55
@NathanWalker NathanWalker merged commit df639ed into NativeScript:alpha May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference between multiple devices in font icon size
2 participants