Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redesigned error activity ui #1776

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

ammarahm-ed
Copy link
Contributor

@ammarahm-ed ammarahm-ed commented Jul 13, 2023

A simple, clean and functional redesign of the error activity the ability to quickly restart the app without restarting the CLI. I also tried my best to prettify the stacktrace so it's more readable, any suggestions are welcome regarding it.

  • Clicking on the file path prints it in adb logcat and if CLI is still connected, it should show the path in terminal

Most of the changes are related to layout xml files.

A screenshot of how the new ErrorActivity looks:

errorac

Compared to:

Screenshot 2023-07-13 at 7 38 27 PM

@cla-bot cla-bot bot added the cla: yes label Jul 13, 2023
@edusperoni
Copy link
Collaborator

My only concern on this is for very long messages.

For example, if the message itself contains a lot of lines (and maybe even a stacktrace), wouldn't the top bar (red) eventually fill the whole screen?

@ammarahm-ed
Copy link
Contributor Author

ammarahm-ed commented Sep 22, 2023

My only concern on this is for very long messages.

For example, if the message itself contains a lot of lines (and maybe even a stacktrace), wouldn't the top bar (red) eventually fill the whole screen?

That is possible but i think it would be rare that the message contains stack trace separately than the one that is already attached to it. The current stack trace is extracted from the long message itself. 🤔

@edusperoni
Copy link
Collaborator

Even if it is rare, we should probably consider it (maybe by limiting the top bar height and allowing scroll on it)

@ammarahm-ed
Copy link
Contributor Author

Agreed, i will try adding something like that and make the top area scrollable.

@ammarahm-ed
Copy link
Contributor Author

Here's what the activity looks like after latest changes:

Screen.Recording.2023-09-30.at.11.02.44.PM.mov

@NathanWalker NathanWalker merged commit ee3e354 into NativeScript:main Oct 6, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants