Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(debugger): console.dir not displayed correctly in Safari inspector #932

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

mbektchiev
Copy link
Contributor

@mbektchiev mbektchiev commented May 30, 2018

Note Merged to release as well (with #935)

consoleAgent prints them correctly only when they're constructed
using the overload accepting ScriptArguments.

Regression has been introduced with #912

PR Checklist

What is the current behavior?

When console.dir({a:1}) is executed by the application or in the console window of Safari Inspector the output contains only undefined.

What is the new behavior?

console.dir correctly displays the object in the console window.

Fixes #930

consoleAgent prints them correctly only when they're constructed
using the overload accepting `ScriptArguments`.

Regression has been introduced with #912
@mbektchiev mbektchiev added this to the 4.1.1 milestone May 30, 2018
@mbektchiev mbektchiev self-assigned this May 30, 2018
@mbektchiev mbektchiev merged commit d97eff7 into master Jun 1, 2018
@mbektchiev mbektchiev deleted the bektchiev/fix-console-dir-in-safari-inspector branch June 1, 2018 10:00
@mbektchiev mbektchiev restored the bektchiev/fix-console-dir-in-safari-inspector branch June 1, 2018 11:01
@mbektchiev mbektchiev deleted the bektchiev/fix-console-dir-in-safari-inspector branch June 1, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants