Skip to content

Return an Unmanaged Type when we don't know how to memory manage an item #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2015
Merged

Return an Unmanaged Type when we don't know how to memory manage an item #386

merged 1 commit into from
Nov 4, 2015

Conversation

KristinaKoeva
Copy link
Contributor

@KristinaKoeva KristinaKoeva added this to the 1.5.0 milestone Oct 27, 2015
jasssonpet
jasssonpet reviewed Nov 2, 2015
View reviewed changes
tests/TestRunner/app/ApiTests.js
@@ -465,6 +465,24 @@ describe(module.id, function () {
expect(TNSReturnsRetained.newNSObjectMethod().retainCount()).toBe(1);
});

it("unmanaged", function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting :)

@jasssonpet jasssonpet changed the title Return an Unmanaged Type when we don't know how to memory managed an item Return an Unmanaged Type when we don't know how to memory manage an item Nov 2, 2015
@KristinaKoeva KristinaKoeva force-pushed the KristinaKoeva/AddUnmanaged branch from be388c2 to 1a944ab Compare November 2, 2015 15:23
fealebenpae
fealebenpae reviewed Nov 2, 2015
View reviewed changes
src/NativeScript/ObjC/Unmanaged/UnmanagedInstance.h
}

private:
void* _data;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this CFTypeRef to make it explicit what we're dealing with.

@jasssonpet
Copy link
Contributor

👍

@KristinaKoeva KristinaKoeva force-pushed the KristinaKoeva/AddUnmanaged branch 2 times, most recently from e8ad340 to d44741f Compare November 4, 2015 09:01
@KristinaKoeva KristinaKoeva force-pushed the KristinaKoeva/AddUnmanaged branch from d44741f to 11891f0 Compare November 4, 2015 09:08
@ivanbuhov
Copy link
Contributor

👍

fealebenpae added a commit that referenced this pull request Nov 4, 2015
@fealebenpae
Merge pull request #386 from NativeScript/KristinaKoeva/AddUnmanaged
0fe21ea 
Return an Unmanaged Type when we don't know how to memory manage an item
@fealebenpae fealebenpae merged commit 0fe21ea into master Nov 4, 2015
@fealebenpae fealebenpae deleted the KristinaKoeva/AddUnmanaged branch November 4, 2015 13:57
@ns-bot
Copy link

ns-bot commented Nov 4, 2015

Test PASSed.

@fealebenpae fealebenpae mentioned this pull request Nov 4, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KristinaKoeva KristinaKoeva

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@KristinaKoeva @jasssonpet @ivanbuhov @ns-bot @fealebenpae