feat: improve robustness of linking with clang path checks #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanWalker
changed the title
NathanWalker
force-pushed
the
fix/metal-toolchain
branch
from
1efec88 to
a5d265d
Compare
Removed early exit on missing toolchain clang and added execution of NS_LD.
NathanWalker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case which made the setup of
nsld.shproblematic was with the known/reported issues with Metal on Xcode 26.https://stackoverflow.com/questions/79660070/xcode-26-metal-compiler-error-metaltoolchain
https://www.reddit.com/r/swift/comments/1lfice9/xcode_cloud_26_doesnt_have_metal_toolchain/
Some projects will have transients that include it and will fail the build during this build script.
It can be ignored when not found, which allows project to build/operate as normal.
This change will link if the path exists, otherwise will skip and log that it skipped it with directory path logged for further debugging if needed.