fix(chrome): new debug url with latest chrome 83+ versions #5319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanaelA
suggested changes
May 30, 2020
There was a problem hiding this comment.
Basically, I think you are adding a lot of extra code that needs to be stripped in a version or two in the future. No need to add the additional complexity, just have it return the "new" correct url that it will be going forward. And add the hard coded temporary url; for those using older Chrome versions. 😀
This comment was marked as abuse.
This comment was marked as abuse.
NathanaelA
approved these changes
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes NativeScript/NativeScript#8605