Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: topological dependency sorting #5647

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Conversation

rigor789
Copy link
Member

@rigor789 rigor789 commented Mar 9, 2022

PR Checklist

What is the current behavior?

Some dependencies are not in the sorted list because of the exit condition and a bug in the reducer.

What is the new behavior?

All dependencies should be in the sorted list now, and sorted correctly.

@cla-bot cla-bot bot added the cla: yes label Mar 9, 2022
@rigor789 rigor789 merged commit 9d8d967 into master Mar 9, 2022
@rigor789 rigor789 deleted the fix/topological-dep-sort branch March 9, 2022 22:20
@rigor789 rigor789 restored the fix/topological-dep-sort branch March 9, 2022 22:20
@rigor789 rigor789 deleted the fix/topological-dep-sort branch April 18, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant