Skip to content

Conversation

NathanWalker
Copy link
Contributor

  • fix NSProxy handling to return valid concrete class
  • fix issue with NSNotification objects
  • add optional sdk tests which can be run in future as well as expanded upon for various sophisticated testing setups with v8

@cla-bot
Copy link

cla-bot bot commented Jun 14, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @NathanWalker.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@NathanWalker
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Jun 14, 2020
@cla-bot
Copy link

cla-bot bot commented Jun 14, 2020

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot
Copy link

cla-bot bot commented Jun 15, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @darind.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot cla-bot bot removed the cla: yes label Jun 15, 2020
@darind darind force-pushed the fix/nsproxy-issue branch from 2016acb to bdc0863 Compare June 15, 2020 18:28
@cla-bot
Copy link

cla-bot bot commented Jun 15, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @darind.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@darind
Copy link
Collaborator

darind commented Jun 15, 2020

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Jun 15, 2020
@cla-bot
Copy link

cla-bot bot commented Jun 15, 2020

The cla-bot has been summoned, and re-checked this pull request!

@NathanWalker NathanWalker merged commit 4aa442a into master Jun 17, 2020
@NathanWalker NathanWalker deleted the fix/nsproxy-issue branch June 17, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants