chore: version bump #7
Conversation
NickIliev
assigned tdermendjiev and mbektchiev and unassigned mbektchiev and tdermendjiev
NickIliev
requested review from
tdermendjiev,
MartoYankov and
mbektchiev
and removed request for
MartoYankov
CoolApp/internal
Outdated
| @@ -0,0 +1 @@ | |||
| /Users/niliev/Desktop/repositories/sample-ios-embedded/nsapp/platforms/ios/internal | |||
There was a problem hiding this comment.
Do we need this symlink checked in? If so you should make it relative instead of absolute to /Users/niliev.
I can see that it's a step that we've written in the README. It's a good idea to remove bothcd .. and ln -s .... steps and add the symlink as relative.
| shellPath = /bin/sh; | ||
| shellScript = "\"${SRCROOT}/Pods/Target Support Files/Pods-CoolApp/Pods-CoolApp-resources.sh\"\n"; | ||
| showEnvVarsInLog = 0; | ||
| }; | ||
| /* End PBXShellScriptBuildPhase section */ |
There was a problem hiding this comment.
Have you intentionally removed this build step? Don't we need it anymore?
There was a problem hiding this comment.
It seems like the app works without it. Maybe we can remove it after all...
There was a problem hiding this comment.
It happened automatically - After rebuild, this step was removed by XCode
| @@ -0,0 +1,14 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
The xcuserdata directory should not be in source control. You'd better remove it and add it to .gitignore.
You can even go further and get all defaults from github's gitignore repo: https://github.com/github/gitignore/blob/master/Global/Xcode.gitignore.
And remove the currently added matching files from the repository
Update versions to latest NativeScript