Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #657 part one #658

Merged
merged 4 commits into from
Dec 5, 2022
Merged

Issue #657 part one #658

merged 4 commits into from
Dec 5, 2022

Conversation

Hugo-ter-Doest
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Dec 5, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3619498500

  • 217 of 257 (84.44%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 87.223%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/natural/tokenizers/parser_sentence_tokenizer.js 215 255 84.31%
Files with Coverage Reduction New Missed Lines %
lib/natural/tokenizers/parser_sentence_tokenizer.js 3 71.7%
Totals Coverage Status
Change from base Build 2672789457: -0.04%
Covered Lines: 9486
Relevant Lines: 10503
💛 - Coveralls

@Hugo-ter-Doest Hugo-ter-Doest merged commit 63d2bb4 into master Dec 5, 2022
@Hugo-ter-Doest Hugo-ter-Doest mentioned this pull request Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hugo-ter-Doest @coveralls