Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path integration: allow different contact force thresholds for different legs, filter contact force signal #145

Merged
merged 18 commits into from
Apr 26, 2024

Conversation

sibocw
Copy link
Contributor

@sibocw sibocw commented Apr 18, 2024

Description

  1. Allow different contact force thresholds (used for stance/swing detection) for fore/mid/hind legs.
  2. Filter contact force signal — hindleg contact might be noisy
  3. Try path integration over complex terrain unrealistic — arena too big and requires very stable physics.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

[list open issues here]

@sibocw sibocw marked this pull request as ready for review April 22, 2024 16:51
@sibocw
Copy link
Contributor Author

sibocw commented Apr 22, 2024

Main changes:

  • Allow different force thresholds for fore/mid/hind legs
  • Added support for blocks terrain, although unused in the end
  • Converted build_models.ipynb into a script
  • Changed parallelism for training data collection: before, exploration.py was has a CLI and a separate script makes multiple calls to the CLI in parallel. Now, we just use joblib.
  • Removed unused legacy code for closed loop homing (not implemented in the end)

Can either @tkclam or @stimpfli take a look please? Thanks!

@sibocw sibocw requested review from tkclam and stimpfli April 22, 2024 16:58
@sibocw sibocw mentioned this pull request Apr 22, 2024
14 tasks
@sibocw
Copy link
Contributor Author

sibocw commented Apr 24, 2024

(Commits up to here are used for v1_SW of the Figure 4a-c)

@sibocw sibocw merged commit 2b0488c into dev-v1.0.0 Apr 26, 2024
9 checks passed
@tkclam
Copy link
Contributor

tkclam commented Apr 26, 2024

@sibocw The code was blocking indefinitely in pool.imap when I ran it, but works well when I use joblib. Everything else is fine other than that.

@sibocw
Copy link
Contributor Author

sibocw commented Apr 26, 2024

@sibocw The code was blocking indefinitely in pool.imap when I ran it, but works well when I use joblib. Everything else is fine other than that.

Did you have to change the code in the end? any idea why?

@tkclam
Copy link
Contributor

tkclam commented Apr 27, 2024

I temporarily changed to using joblib to get it to run. Not sure why multiprocessing didn't work

@sibocw
Copy link
Contributor Author

sibocw commented Apr 27, 2024

do you want to push your version to dev-v1.0.0?

@tkclam
Copy link
Contributor

tkclam commented Apr 29, 2024

done

@sibocw sibocw deleted the path-integration branch April 29, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants