[WIP] Feature: modules #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why modules should be part of Widget instead of a part of VM? Also what about recursive modules? |
|
@evgenykuzyakov So this was my first work on VM, and my initial idea was to make changes to Widget.js. From your comment, I understand that the changes should be done in the initial VM (https://github.com/NearSocial/VM/blob/master/src/lib/vm/vm.js) Could you please provide some details about how it should be implemented? |
|
Transferred issue #17 from the viewer repo. Let's discuss in the issue |
Closed
marcinbodnar
force-pushed
the
feat/36
branch
2 times, most recently
from
32c7e18
to
e3edb8f
Compare
|
Addressed in #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.