New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize formatter::format to use with FMT_COMPILE #365

Merged

Neargye merged 1 commit into Neargye:master from ArtfulVampire:parameterize_format

Jul 8, 2024

Contributor

ArtfulVampire commented Jul 8, 2024

fmtlib/fmt#4059 (comment)

tested by adding fmt library into make_test and running the case

TEST_CASE("format-fmt") {
  REQUIRE(fmt::format("{}", Color::RED) == "red");
  REQUIRE(fmt::format("{}", Color{0}) == "0");

  REQUIRE(fmt::format(FMT_STRING("{}"), Color::RED) == "red");
  REQUIRE(fmt::format(FMT_STRING("{}"), Color{0}) == "0");

  REQUIRE(fmt::format(FMT_COMPILE("{}"), Color::RED) == "red");
  REQUIRE(fmt::format(FMT_COMPILE("{}"), Color{0}) == "0");
}


          Parameterize formatter::format to use with FMT_COMPILE

3549ccd

ArtfulVampire marked this pull request as ready for review

July 8, 2024 15:26

Owner

Neargye commented Jul 8, 2024

Thanks!

Neargye merged commit 664ee62 into Neargye:master

18 checks passed

Neargye mentioned this pull request

std::format() and std::print() support? #334

Closed

Neargye added this to the v0.9.7 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet